Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: allow ability to add new attributes to refinery data #621

Merged
merged 5 commits into from
Mar 7, 2023
Merged

feat: allow ability to add new attributes to refinery data #621

merged 5 commits into from
Mar 7, 2023

Conversation

fchikwekwe
Copy link
Contributor

@fchikwekwe fchikwekwe commented Mar 2, 2023 •
edited
Loading

Which problem is this PR solving?

Short description of the changes

  • Allows user to define additional attributes that will show up as fields in refinery data.

@fchikwekwe fchikwekwe requested a review from a team as a code owner March 2, 2023 16:47
@fchikwekwe fchikwekwe changed the title Faith/add attributes to metrics add: allow ability to add new attributes to refinery data Mar 2, 2023
@fchikwekwe fchikwekwe force-pushed the faith/add-attributes-to-metrics branch from 305f14c to 1129147 Compare March 2, 2023 16:52
@fchikwekwe fchikwekwe changed the title add: allow ability to add new attributes to refinery data feat: allow ability to add new attributes to refinery data Mar 2, 2023
@fchikwekwe fchikwekwe force-pushed the faith/add-attributes-to-metrics branch from 1129147 to 6d31902 Compare March 2, 2023 16:57
@fchikwekwe fchikwekwe added type: enhancement New feature or request status: review needed Changes need review. version: bump minor A PR that adds behavior, but is backwards-compatible. merge at will Reviewer can merge the PR once reviewed. labels Mar 2, 2023
@fchikwekwe fchikwekwe self-assigned this Mar 2, 2023
TylerHelmuth
TylerHelmuth approved these changes Mar 3, 2023
View reviewed changes
config_complete.toml Outdated Show resolved Hide resolved
fchikwekwe and others added 3 commits March 7, 2023 10:40
@fchikwekwe @TylerHelmuth
Update config_complete.toml
4bf3040 
Co-authored-by: Tyler Helmuth <12352919+TylerHelmuth@users.noreply.github.com>
@fchikwekwe
Merge branch 'main' into faith/add-attributes-to-metrics
b84ebac
@fchikwekwe
test: try to fix race
16a77da
@fchikwekwe fchikwekwe merged commit 517e2ba into main Mar 7, 2023
@fchikwekwe fchikwekwe deleted the faith/add-attributes-to-metrics branch March 7, 2023 17:01
@fchikwekwe fchikwekwe mentioned this pull request Mar 7, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@TylerHelmuth TylerHelmuth TylerHelmuth approved these changes

Assignees

@fchikwekwe fchikwekwe

Labels
merge at will Reviewer can merge the PR once reviewed. status: review needed Changes need review. type: enhancement New feature or request version: bump minor A PR that adds behavior, but is backwards-compatible.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add arbitrary static attribute name/values to refinery telemetry
2 participants
@fchikwekwe @TylerHelmuth