Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: publish should only happen on main #627

Merged
merged 1 commit into from
Mar 5, 2023
Merged

chore: publish should only happen on main #627

merged 1 commit into from
Mar 5, 2023

Conversation

kentquirk
Copy link
Contributor

Which problem is this PR solving?

  • The ECR publish should only happen on pushes to main, for two reasons:
    • not every branch (like dependabot's branches) has a right to do it
    • we deploy on push to main, and that's what uses this publish

Short description of the changes

  • change workflow so it only applies to the main branch

@kentquirk kentquirk requested a review from a team as a code owner March 4, 2023 22:13
@kentquirk kentquirk added type: maintenance The necessary chores to keep the dust off. version: no-bump labels Mar 4, 2023
@kentquirk kentquirk requested a review from RainofTerra March 4, 2023 22:14
@kentquirk kentquirk merged commit c26f377 into main Mar 5, 2023
@kentquirk kentquirk deleted the kent.ecr_on_main branch March 5, 2023 16:16
@codeboten codeboten added version: no bump A PR with maintenance or doc changes that aren't included in a release. and removed version: no-bump labels Mar 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@TylerHelmuth TylerHelmuth TylerHelmuth approved these changes

@RainofTerra RainofTerra Awaiting requested review from RainofTerra

Assignees
No one assigned
Labels
type: maintenance The necessary chores to keep the dust off. version: no bump A PR with maintenance or doc changes that aren't included in a release.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@kentquirk @TylerHelmuth @codeboten