Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

maint: Add LICENSES dir #638

Merged
merged 3 commits into from
Mar 21, 2023
Merged

maint: Add LICENSES dir #638

merged 3 commits into from
Mar 21, 2023

Conversation

TylerHelmuth
Copy link
Contributor

Which problem is this PR solving?

  • Adds LICENSES folder with all required licenses/notices

Short description of the changes

  • Adds licenses/notices to LICENSES folder
  • Adds a check to the build job that ensures the LICENSES folder is up-to-date.

@TylerHelmuth TylerHelmuth marked this pull request as ready for review March 16, 2023 22:07
@TylerHelmuth TylerHelmuth requested a review from a team as a code owner March 16, 2023 22:07
@kentquirk
Copy link
Contributor

Additional requests:

  • Can you add an "update-licenses" Make target also, please, and maybe have the verify task say how to run it?
  • Is just stuffing these into our repo enough, or do we also need to attach them to the built artifacts somehow?

@TylerHelmuth
Copy link
Contributor Author

Can you add an "update-licenses" Make target also, please, and maybe have the verify task say how to run it?

Will do

Is just stuffing these into our repo enough, or do we also need to attach them to the built artifacts somehow?

As I understand it, we do need to update some stuff about our build, mainly some adding some important labels to the image that points back to this folder. I plan to do that in a separate PR.

@kentquirk kentquirk added the no-changelog Omit this PR from changelog/release notes. label Mar 20, 2023
@TylerHelmuth TylerHelmuth merged commit 1f9e619 into main Mar 21, 2023
@TylerHelmuth TylerHelmuth deleted the tyler.add-licenses-dir branch March 21, 2023 15:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
no-changelog Omit this PR from changelog/release notes.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants