Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: correct syntax error in config_complete.toml #639

Merged
merged 1 commit into from
Mar 20, 2023

Conversation

hazelweakly
Copy link
Contributor

Which problem is this PR solving?

This PR fixes a small syntax error in the config_complete.toml file.
It's not a huge deal, but I tend to uncomment lines and go from there and didn't read the line closely enough before uncommenting it; I suspect another tired person would make a similar mistake :)

Short description of the changes

It makes the strings stringier

@hazelweakly hazelweakly requested a review from a team as a code owner March 17, 2023 17:16
Copy link
Contributor

@TylerHelmuth TylerHelmuth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@hazelweakly Thanks for taking care of this! I'm surprised it caused an error tho bc the original format should still be interpreted as a string. What error were you seeing?

@kentquirk
Copy link
Contributor

@hazelweakly is correct -- YAML will interpret this correctly, but TOML is more rigid.

'toml: expected newline but got U+0073 's'' loading config from config_complete.toml with filetype

Thanks for the PR!

@TylerHelmuth TylerHelmuth merged commit c084fa7 into honeycombio:main Mar 20, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants