Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Update MetricsReportingInterval in config_complete.toml #653

Merged
merged 2 commits into from
Apr 6, 2023

Conversation

tdarwin
Copy link
Contributor

@tdarwin tdarwin commented Apr 2, 2023

Which problem is this PR solving?

  • Some folks are sending metrics to Honeycomb much more frequently than necessary. 30 seconds should give plenty of data to understand things happening with Refinery and reduce the number of events being sent to be less overwhelming

Short description of the changes

  • Changes the example MetricsReportingInterval in the Honeycomb Metrics config section to be 30 instead of 3.

@tdarwin tdarwin requested a review from a team as a code owner April 2, 2023 15:28
@tdarwin tdarwin changed the title Update MetricsReportingInterval in config_complete.toml Chore: Update MetricsReportingInterval in config_complete.toml Apr 2, 2023
@tdarwin tdarwin changed the title Chore: Update MetricsReportingInterval in config_complete.toml chore: Update MetricsReportingInterval in config_complete.toml Apr 2, 2023
Copy link
Contributor

@kentquirk kentquirk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This change is fine in general, but I'll note that a long reporting interval is a problem during setup when you're trying to right-size memory and queue sizes; issues can and will arise and completely vanish between reporting periods.

When I've been working with customers lately, I ask them to set it to 1 second while we debug.

@kentquirk kentquirk added this to the v1.21 milestone Apr 2, 2023
@kentquirk kentquirk added type: maintenance The necessary chores to keep the dust off. version: no bump A PR with maintenance or doc changes that aren't included in a release. labels Apr 2, 2023
@fchikwekwe fchikwekwe merged commit 83625bf into main Apr 6, 2023
@fchikwekwe fchikwekwe deleted the tdarwin/update_metrics_reporting_interval branch April 6, 2023 16:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type: maintenance The necessary chores to keep the dust off. version: no bump A PR with maintenance or doc changes that aren't included in a release.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants