Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: validate cache overrun strategy for stress relief mode #664

Merged
merged 7 commits into from
Apr 14, 2023

Conversation

fchikwekwe
Copy link
Contributor

Closes #637

Validate that the cache overrun strategy is set to "impact" before allowing stress relief mode

@fchikwekwe fchikwekwe marked this pull request as ready for review April 13, 2023 15:11
@fchikwekwe fchikwekwe requested a review from a team as a code owner April 13, 2023 15:11
@fchikwekwe fchikwekwe requested a review from TylerHelmuth April 13, 2023 15:12
Copy link
Contributor

@TylerHelmuth TylerHelmuth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please add a new test to config_test.go that covers the new validation.

config/file_config.go Outdated Show resolved Hide resolved
@fchikwekwe fchikwekwe force-pushed the faith/valide-cache-strategy branch from 4dd31a1 to 66a7199 Compare April 13, 2023 19:15
@fchikwekwe fchikwekwe requested a review from TylerHelmuth April 13, 2023 19:17
@fchikwekwe fchikwekwe force-pushed the faith/valide-cache-strategy branch from cd70c44 to 8447851 Compare April 14, 2023 14:46
@fchikwekwe fchikwekwe force-pushed the faith/valide-cache-strategy branch from a191739 to f068719 Compare April 14, 2023 14:48
config/file_config.go Outdated Show resolved Hide resolved
Co-authored-by: Tyler Helmuth <12352919+TylerHelmuth@users.noreply.github.com>
Copy link
Contributor

@TylerHelmuth TylerHelmuth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@fchikwekwe fchikwekwe merged commit 54a5640 into main Apr 14, 2023
@fchikwekwe fchikwekwe deleted the faith/valide-cache-strategy branch April 14, 2023 15:23
@TylerHelmuth TylerHelmuth added this to the v1.21 milestone Apr 17, 2023
kentquirk pushed a commit that referenced this pull request May 8, 2023
Closes #637 

Validate that the cache overrun strategy is set to "impact" before
allowing stress relief mode

---------

Co-authored-by: Tyler Helmuth <12352919+TylerHelmuth@users.noreply.github.com>
kentquirk added a commit that referenced this pull request May 8, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

StressRelief mode is not compatible with Legacy CacheOverrunStrategy
2 participants