fix: check apikeys for otlp requests too (+tests) #672
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -37,6 +37,25 @@ func (r *Router) queryTokenChecker(next http.Handler) http.Handler { | |||
| }) | |||
| } | |||
|
|
|||
| func (r *Router) isKeyAllowed(key string) bool { | |||
There was a problem hiding this comment.
Since this is called on every request, it could be nice to be able to check the key in a map instead of looping through a slice each time.
There was a problem hiding this comment.
Doing that would require changing the data type of the config value to a map, and writing code that parses the current configuration into it both on initial load and on reload. It's a good idea, but it's something that a) we've already lived with for a long time, b) in practice might even be more expensive because most installations just have ["*"] as the value, and c) and I'd rather do it as a separate issue as part of the config rework.
TylerHelmuth
approved these changes
Apr 28, 2023
kentquirk
added a commit
that referenced
this pull request
May 8, 2023
## Which problem is this PR solving? - #671 -- Refinery's APIKeys configuration value was not being used for OTel requests ## Short description of the changes - Refactor middleware to pull out the key-validation logic - Use it in the http middleware - Call it in the OTLP handler - Add a normal (mocked) test for OTLP - Add an integration test for HTTP
kentquirk
added a commit
that referenced
this pull request
May 8, 2023
## Which problem is this PR solving? - #671 -- Refinery's APIKeys configuration value was not being used for OTel requests ## Short description of the changes - Refactor middleware to pull out the key-validation logic - Use it in the http middleware - Call it in the OTLP handler - Add a normal (mocked) test for OTLP - Add an integration test for HTTP
kentquirk
added a commit
that referenced
this pull request
May 8, 2023
## Which problem is this PR solving? - #671 -- Refinery's APIKeys configuration value was not being used for OTel requests ## Short description of the changes - Refactor middleware to pull out the key-validation logic - Use it in the http middleware - Call it in the OTLP handler - Add a normal (mocked) test for OTLP - Add an integration test for HTTP
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which problem is this PR solving?
Short description of the changes