-
Notifications
You must be signed in to change notification settings - Fork 95
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Refactoring of rules configuration and rules converter #681
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kentquirk
added
breaking-change
Prefer 'version: bump major', but use this for breaking changes that don't bump major.
wip
Work In Progress
labels
May 15, 2023
kentquirk
force-pushed
the
kent.v2.convert_rules
branch
from
May 15, 2023 22:24
009ff7e
to
472916c
Compare
TylerHelmuth
approved these changes
May 17, 2023
TylerHelmuth
approved these changes
May 17, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
breaking-change
Prefer 'version: bump major', but use this for breaking changes that don't bump major.
wip
Work In Progress
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which problem is this PR solving?
This is a reworking of the refinery rules structure. The existing rules configuration format is both awkwardly structured for technical reasons, as well as just being confusing. People make a lot of mistakes.
This structure organizes refinery rules into a map of environment name (dataset in classic mode) to sampler config, and reserves the name
__default__
for the default case. It also puts the sampler configurations indented under the sampler type, which avoids another level of confusion.Short description of the changes
This work isn't "done" (there is more planned) but it's stable enough to call it a checkpoint, review as-is, and do the next things as separate PRs.