Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Various config fixes #684

Merged
merged 1 commit into from
May 18, 2023
Merged

fix: Various config fixes #684

merged 1 commit into from
May 18, 2023

Conversation

kentquirk
Copy link
Contributor

Which problem is this PR solving?

Several issues with config in progress.

Short description of the changes

  • A bug in Refinery v1 means that some configs will have values under SampleCache, and others under SampleCacheConfig. This gives us the ability to use both.
  • There was a vertical spacing error in doc generation
  • Add default values to the generated config
  • Differentiate between values we always want and values where we always want to show an example.
  • Regenerate the generated files with all of the above.

@kentquirk kentquirk requested a review from a team as a code owner May 17, 2023 23:49
@kentquirk kentquirk changed the title Various config fixes fix: Various config fixes May 18, 2023
@kentquirk kentquirk merged commit 214fe95 into main May 18, 2023
@kentquirk kentquirk deleted the kent.more_config branch May 18, 2023 00:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@TylerHelmuth TylerHelmuth TylerHelmuth approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@kentquirk @TylerHelmuth