feat: Remove trace key params -> add meta sample_key #685
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which problem is this PR solving?
Refinery had rules configuration for dynamic samplers to "AddSampleRateKeyToTrace" which would inject the sample rate key into a field of the user's choice. We also have, in the normal configuration "AddRuleReasonToTrace", which also injected that key but as part of the rule reason in
meta.refinery.reason
, causing people to have to write derived columns to pull it off.This PR addresses both of those.
Short description of the changes
AddSampleRateKeyToTrace
andAddSampleRateKeyToTraceField
params from samplersmeta.refinery.sample_key
This looks big but it's a lot of small identical changes in multiple files.