-
Notifications
You must be signed in to change notification settings - Fork 95
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: [v2] Use the new configuration system #690
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I expected to see the new that new throughput sampler set as the default sampler in the rules. Are we still doing that and should it be part of this PR?
The new samplers will come in a separate PR. |
TylerHelmuth
approved these changes
May 26, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
breaking-change
Prefer 'version: bump major', but use this for breaking changes that don't bump major.
version: bump major
A PR that breaks backwards compatibility.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This converts refinery to use the new configuration model that we've been moving towards
This is an enormous PR because there really wasn't a good way to change to a new configuration model slowly; it affected a lot of support code and tests.
Key elements include:
3m30s
or100ms
).There is still work to do before this can be released, but it's passing tests and I can go back to smaller PRs after this.
This closes a few of the planned issues for 2.0:
Closes #667
Closes #655
Closes #581