feat: Add WindowedThroughput sampler #709
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Merged
kentquirk
force-pushed
the
kent.add_windowedthroughput
branch
from
e3d06ce to
2ed3ee3
Compare
TylerHelmuth
approved these changes
Jun 9, 2023
| @@ -402,6 +402,111 @@ groups: | |||
| is a useful indicator of traces you'd like to see in Honeycomb, set | |||
| this to true. | |||
|
|
|||
| - name: WindowedThroughputSampler | |||
There was a problem hiding this comment.
Do we even need the ThroughputSampler anymore?
There was a problem hiding this comment.
Yes, mainly for compatibility. I do hope to deprecate it but don't think we need to do that for 2.0.
kentquirk
added a commit
that referenced
this pull request
Jun 9, 2023
Depends on #709 ## Which problem is this PR solving? - The MaxKeys value is supported in most samplers, but it wasn't always included in the config - It defaulted to 0 which means "no max" -- Honeycomb CAs agree this is not a useful setting. ## Short description of the changes - Support MaxKeys in all dynamic samplers - 0 now means 500
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Depends on #708
Which problem is this PR solving?
Short description of the changes