feat: preregister libhoney metrics #716
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TylerHelmuth
requested changes
Jun 16, 2023
Comment on lines
+147
to
+153
| "queue_length": "gauge", | ||
| "queue_overflow": "counter", | ||
| "send_errors": "counter", | ||
| "send_retries": "counter", | ||
| "batches_sent": "counter", | ||
| "messages_sent": "counter", | ||
| "response_decode_errors": "counter", |
There was a problem hiding this comment.
I am a little worried about keeping this list up-to-date as libhoney changes. Is there any way to expose a "register" method in libhoney to do this work for us?
I don't want to block on this, but would be nice in the future.
There was a problem hiding this comment.
I hear that, but libhoney-go is old and really doesn't get new features any more. It did get a dependency bump 2 weeks ago, but the last change before that was last fall. I don't believe anyone but a small number of refinery users cares about this, and the backwards-compatible version of this change is kind of ugly.
TylerHelmuth
approved these changes
Jun 16, 2023
|
Accidentally clicked the wrong response lol |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which problem is this PR solving?
Short description of the changes