Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: make refinery run from minimal config #724

Merged
merged 10 commits into from
Jun 21, 2023
Merged

Conversation

kentquirk
Copy link
Contributor

@kentquirk kentquirk commented Jun 18, 2023

Which problem is this PR solving?

  • All the config changes had some minor issues that kept refinery from starting up with minimal configuration. This fixes that.

Short description of the changes

  • logrus -> stdout
  • fix sequencing of metrics startup
  • fix default peer for file-based peer list
  • add UnmarshalText method to log level
  • the injection system was randomly starting up the transmissions before the metrics object, which shouldn't have been possible. I couldn't figure out why it was happening, so we now call start on transmissions manually after everything else.

@kentquirk kentquirk requested a review from a team as a code owner June 18, 2023 18:56
@kentquirk kentquirk added this to the v2.0 milestone Jun 19, 2023
@kentquirk kentquirk changed the base branch from kent.fix_sharder to main June 20, 2023 21:43
Copy link
Contributor

@TylerHelmuth TylerHelmuth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@kentquirk looks like there might be a bad rebase in here

sharder/deterministic.go Outdated Show resolved Hide resolved
config.yaml Show resolved Hide resolved
@kentquirk kentquirk requested a review from TylerHelmuth June 20, 2023 23:17
@TylerHelmuth TylerHelmuth merged commit d8ab5b3 into main Jun 21, 2023
@TylerHelmuth TylerHelmuth deleted the kent.fix_startup branch June 21, 2023 15:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants