Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: enable pyroscope deltaprof #747

Merged
merged 1 commit into from
Jun 26, 2023
Merged

feat: enable pyroscope deltaprof #747

merged 1 commit into from
Jun 26, 2023

Conversation

lizthegrey
Copy link
Member

Which problem is this PR solving?

  • On long-lived services like Refinery with large process uptimes, the number of distinct stacks and code addresses grows in the profile as time goes on; this causes high numbers of bytes to be scraped when collecting profiles for timeseries that aren't increasing in value very often but have been seen at least once in process lifetime.

Short description of the changes

@lizthegrey lizthegrey requested a review from a team as a code owner June 26, 2023 21:41
@lizthegrey lizthegrey changed the title enable pyroscope deltaprof feat: enable pyroscope deltaprof Jun 26, 2023
@lizthegrey lizthegrey requested a review from TylerHelmuth June 26, 2023 22:23
Copy link
Contributor

@TylerHelmuth TylerHelmuth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't know anything about profiling but all the names line up. With 2.0 coming out so soon I'd like @kentquirk review and also opinion on whether this should be included in 2.0 or 2.1.

@lizthegrey
Copy link
Member Author

I don't know anything about profiling but all the names line up. With 2.0 coming out so soon I'd like @kentquirk review and also opinion on whether this should be included in 2.0 or 2.1.

It's the same code as is in hound if there are any concerns :)

@lizthegrey lizthegrey merged commit 877ab8f into main Jun 26, 2023
@lizthegrey lizthegrey deleted the lizf.debugsvc branch June 26, 2023 22:32
lizthegrey added a commit that referenced this pull request Jun 26, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants