Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Query auth bug fix; add tests #753

Merged
merged 1 commit into from
Jun 29, 2023
Merged

fix: Query auth bug fix; add tests #753

merged 1 commit into from
Jun 29, 2023

Conversation

kentquirk
Copy link
Contributor

Which problem is this PR solving?

  • The QueryAuthToken auth middleware had a bug where it would return an error and ALSO return the requested result even when auth failed.

Short description of the changes

  • Add a missing return statement.
  • Write several tests that would have caught the missing return statement and a bunch of other possible issues.

@kentquirk kentquirk requested a review from a team as a code owner June 29, 2023 14:36
@kentquirk kentquirk added this to the v2.0 milestone Jun 29, 2023
@kentquirk kentquirk merged commit a29c7f6 into main Jun 29, 2023
@kentquirk kentquirk deleted the kent.fix_queryauth branch June 29, 2023 14:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@TylerHelmuth TylerHelmuth TylerHelmuth approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
v2.0
Development

Successfully merging this pull request may close these issues.
2 participants
@kentquirk @TylerHelmuth