Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Fix bugs with convert #764

Merged
merged 3 commits into from
Jul 10, 2023
Merged

fix: Fix bugs with convert #764

merged 3 commits into from
Jul 10, 2023

Conversation

TylerHelmuth
Copy link
Contributor

@TylerHelmuth TylerHelmuth commented Jul 6, 2023

Which problem is this PR solving?

Short description of the changes

  • Fix 2 template typos.

Input:

config:
  APIKeys: 
    - test-key
  InMemCollector:
    MaxAlloc: 3865470566

Command: convert helm -i test.yaml -o result.yaml

Before output:

config:
    AccessKeys:
        AcceptOnlyListedKeys: true
    General:
        ConfigurationVersion: 2
        MinRefineryVersion: v2.0

After output:

config:
    AccessKeys:
        AcceptOnlyListedKeys: true
        ReceiveKeys:
            - test-key
    Collection:
        MaxAlloc: 3.865GB
    General:
        ConfigurationVersion: 2
        MinRefineryVersion: v2.0

@TylerHelmuth TylerHelmuth requested a review from a team as a code owner July 6, 2023 19:16
tools/convert/helpers.go Show resolved Hide resolved
@TylerHelmuth TylerHelmuth added the version: bump patch A PR with release-worthy changes and is backwards-compatible. label Jul 6, 2023
Copy link
Member

@cartermp cartermp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We'll also want to update the docs repo with this change once it's in.

@TylerHelmuth TylerHelmuth added this to the v2.0.1 milestone Jul 7, 2023
@TylerHelmuth
Copy link
Contributor Author

@cartermp I'll get the docs repo updated in a single PR once all these 2.0.1 PRs are merged.

@TylerHelmuth TylerHelmuth merged commit 40d9ec5 into main Jul 10, 2023
@TylerHelmuth TylerHelmuth deleted the tyler.fix-converter-bug branch July 10, 2023 15:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
version: bump patch A PR with release-worthy changes and is backwards-compatible.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Convert does not correctly convert MaxAlloc or APIKeys
4 participants