Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: hack a fix for adjustmentinterval not converting inside rules based samples #768

Merged
merged 3 commits into from
Jul 10, 2023

Conversation

TylerHelmuth
Copy link
Contributor

@TylerHelmuth TylerHelmuth commented Jul 6, 2023

Which problem is this PR solving?

Short description of the changes

  • hacks away at an issue where the convert tool couldnt handle the []Rules in the rules based sampler.

@TylerHelmuth TylerHelmuth requested a review from a team as a code owner July 6, 2023 23:06
Copy link
Member

@cartermp cartermp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I was going to ask about a representative test case, but it appears that testing for this isn't really representative. Given that this is a delightfully hacky fix, I think we should have a test that exemplifies the weird config people could do in the 1.x world that results in this bug.

@TylerHelmuth
Copy link
Contributor Author

@cartermp added another test case that handles the slice issue, but not the config.Duration change. I'd like to take a look at this issue with fresh eyes anyways, this PR is more to show what the issue is.

@TylerHelmuth TylerHelmuth added the version: bump patch A PR with release-worthy changes and is backwards-compatible. label Jul 7, 2023
@TylerHelmuth TylerHelmuth added this to the v2.0.1 milestone Jul 7, 2023
@TylerHelmuth TylerHelmuth merged commit 3076db2 into main Jul 10, 2023
@TylerHelmuth TylerHelmuth deleted the tyler.adjustmentinterval-hack branch July 10, 2023 20:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
version: bump patch A PR with release-worthy changes and is backwards-compatible.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Convert does not correctly handle converting EMADynamicSamplerConfig.AdjustmentInterval
3 participants