fix: Add missing validation for LegacyMetrics APIKey #774
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TylerHelmuth
added
the
version: bump patch
akvanhar
approved these changes
Jul 7, 2023
refinery_rules.md
Outdated
| @@ -77,7 +77,7 @@ The sample rate is calculated from the trace ID, so all spans with the same trac | |||
|
|
|||
| The duration after which the Dynamic Sampler should reset its internal counters. | |||
| It should be specified as a duration string. | |||
| For example, "30s" or "1m". | |||
| For example,"30s" or "1m". | |||
There was a problem hiding this comment.
🤨 We should probably have the space here. Was it auto-formatted out?
|
The reason this wasn't specified as an apikey format is that we often have example files that specify "yourkeyhere" or something like it -- for classic keys, that won't conform to the format. "SetThisToAHoneycombKey" is a valid modern format. I'm OK with enforcing it but it might cause some problems with demo data. |
TylerHelmuth
force-pushed
the
tyler.add-missing-validation
branch
from
461c1c4 to
6bacb6b
Compare
TylerHelmuth
force-pushed
the
tyler.add-missing-validation
branch
from
6bacb6b to
921d22b
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which problem is this PR solving?
LegacyMetrics.APIKey.Short description of the changes