Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Add ability to handle k8s unit format #778

Merged
merged 2 commits into from
Jul 10, 2023
Merged

fix: Add ability to handle k8s unit format #778

merged 2 commits into from
Jul 10, 2023

Conversation

TylerHelmuth
Copy link
Contributor

Which problem is this PR solving?

Short description of the changes

  • Updates MemorySize.UnmarshalText to be able to handle k8s memory format.
  • Add unit tests

@TylerHelmuth TylerHelmuth added the version: bump patch A PR with release-worthy changes and is backwards-compatible. label Jul 9, 2023
@TylerHelmuth TylerHelmuth requested a review from a team as a code owner July 9, 2023 21:51
@TylerHelmuth TylerHelmuth added this to the v2.0.1 milestone Jul 9, 2023
kentquirk
kentquirk approved these changes Jul 10, 2023
View reviewed changes
Copy link
Contributor

@kentquirk kentquirk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a good solution.

@TylerHelmuth TylerHelmuth force-pushed the tyler.k8s-compatible-units branch from 68689c8 to 999a542 Compare July 10, 2023 15:16
@TylerHelmuth TylerHelmuth merged commit b3094d6 into main Jul 10, 2023
@TylerHelmuth TylerHelmuth deleted the tyler.k8s-compatible-units branch July 10, 2023 16:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kentquirk kentquirk kentquirk approved these changes

Assignees
No one assigned
Labels
version: bump patch A PR with release-worthy changes and is backwards-compatible.
Projects
None yet
Milestone
v2.0.1
Development

Successfully merging this pull request may close these issues.
2 participants
@TylerHelmuth @kentquirk