Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Inject all metrics and config later #780

Merged
merged 1 commit into from
Jul 10, 2023
Merged

fix: Inject all metrics and config later #780

merged 1 commit into from
Jul 10, 2023

Conversation

kentquirk
Copy link
Contributor

@kentquirk kentquirk commented Jul 10, 2023 •
edited
Loading

Which problem is this PR solving?

  • We had missing metrics because the metrics objects that were loaded from config were not being Start()ed.

Short description of the changes

  • Rework MultiMetrics to inject all the internal implementations even if they're not being used.
  • On Start(), copy the enabled ones to the children list so that the rest of metrics works right.
  • Remove the previous attempt to avoid doing this.
  • Also inject All The Things into a test that needs injection.

Fixes #776.

@kentquirk kentquirk requested a review from a team as a code owner July 10, 2023 19:09
@kentquirk kentquirk changed the title Inject all metrics and config later fix: Inject all metrics and config later Jul 10, 2023
@kentquirk kentquirk added this to the v2.0.1 milestone Jul 10, 2023
@kentquirk kentquirk force-pushed the kent.fix_metrics_injection branch from fbd153e to 5b3467f Compare July 10, 2023 19:11
TylerHelmuth
TylerHelmuth approved these changes Jul 10, 2023
View reviewed changes
Copy link
Contributor

@TylerHelmuth TylerHelmuth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Best of both worlds

@kentquirk kentquirk merged commit 31b3ec6 into main Jul 10, 2023
@kentquirk kentquirk deleted the kent.fix_metrics_injection branch July 10, 2023 19:24
@kentquirk kentquirk mentioned this pull request Jul 13, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@TylerHelmuth TylerHelmuth TylerHelmuth approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
v2.0.1
Development

Successfully merging this pull request may close these issues.

Some Refinery metrics are not working correctly
2 participants
@kentquirk @TylerHelmuth