Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Extended validation of config files #781

Merged
merged 1 commit into from
Jul 11, 2023
Merged

Conversation

kentquirk
Copy link
Contributor

Which problem is this PR solving?

  • Config file validation did not include any values specified on the command line or in the environment.

Short description of the changes

  • After initial validation of the raw config, we unmarshal it into a config structure, write it back out to a local YAML buffer, and then revalidate the now-hydrated config. This also required masking the keys in the error output, injecting fake keys if they weren't specified at all, and fixing a test.

Fixes #775.

@kentquirk kentquirk requested a review from a team as a code owner July 10, 2023 21:11
@TylerHelmuth TylerHelmuth added this to the v2.0.1 milestone Jul 10, 2023
@kentquirk kentquirk merged commit d068946 into main Jul 11, 2023
@kentquirk kentquirk deleted the kent.extended_validation branch July 11, 2023 14:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

HoneycombLogger requires APIKey when dataset is set, even if APIKey is being supplied by an env var
2 participants