Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: General Improvements #789

Merged
merged 2 commits into from
Jul 11, 2023
Merged

docs: General Improvements #789

merged 2 commits into from
Jul 11, 2023

Conversation

mjingle
Copy link
Contributor

@mjingle mjingle commented Jul 11, 2023

Which problem is this PR solving?

This PR includes some improvements for generated documentation for Honeycomb docs site to match style guide standards. For example, "etc." is an abbreviation of a Latin expression - and the Honeycomb docs use American English only - but at the very least should have a period included when used.

This PR should also include a comma between generated options, but I will need @kentquirk's help with wrangling that.
For example, the options for https://docs.honeycomb.io/manage-data-volume/refinery/configuration/#type should have commas between them to improve clarity.

Screenshot 2023-07-11 at 3 31 05 PM

Short description of the changes

  • Refer to above

Signed-off-by: Mary Jinglewski <maryjinglewski@honeycomb.io>
@mjingle mjingle added wip Work In Progress type: documentation labels Jul 11, 2023
@mjingle mjingle requested a review from a team as a code owner July 11, 2023 19:32
@kentquirk
Copy link
Contributor

I've updated the template to add commas and break it up into separate values, and regenerated.

@kentquirk kentquirk merged commit 5e4b444 into main Jul 11, 2023
@kentquirk kentquirk deleted the mj.RDocsImprovements branch July 11, 2023 21:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants