Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

maint: Docker tagging updates #791

Merged
merged 2 commits into from
Jul 12, 2023
Merged

maint: Docker tagging updates #791

merged 2 commits into from
Jul 12, 2023

Conversation

RainofTerra
Copy link
Contributor

Which problem is this PR solving?

#790

Short description of the changes

  • For internal dev builds, the version will be the build # from circle. They will also be tagged with this build number
  • The tags for dev builds will include branch-branchname such as branch-terra.myawesomebranch
  • For internal dev builds for main will be tagged with latest
  • For releases, we will tag with major, major.minor, and semver in addition to latest (for compatibility) such as 2, 2.1, and 2.1.5
  • All dev builds will now be available in our ECR repo, I will separately add a lifecycle policy to it so it only keeps so many days of non-release builds (90 maybe?)

@RainofTerra RainofTerra requested a review from a team as a code owner July 11, 2023 23:34
@TylerHelmuth TylerHelmuth changed the title Docker tagging updates maint: Docker tagging updates Jul 12, 2023
TylerHelmuth
TylerHelmuth reviewed Jul 12, 2023
View reviewed changes
build-docker.sh Show resolved Hide resolved
build-docker.sh Show resolved Hide resolved
@RainofTerra RainofTerra merged commit a27492a into main Jul 12, 2023
@RainofTerra RainofTerra deleted the terra.docker_tagging_updates branch July 12, 2023 16:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@TylerHelmuth TylerHelmuth TylerHelmuth approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@RainofTerra @TylerHelmuth