Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: refinery_rules.md #802

Merged
merged 7 commits into from
Aug 1, 2023
Merged

docs: refinery_rules.md #802

merged 7 commits into from
Aug 1, 2023

Conversation

RainofTerra
Copy link
Contributor

@RainofTerra RainofTerra commented Jul 19, 2023

Which problem is this PR solving?

  • Documentation updates
    • Link to complete refinery rules example
    • generates options/choices for Datatype
    • generates options/choices for all valid operators for conditions

Short description of the changes

  • This PR just adds a link to the rules_complete.yaml file since that file can be helpful in understanding what a full rules yaml file might look like, and adds the list of valid values for Datatype'

Fixes #804

@RainofTerra RainofTerra requested a review from mjingle July 19, 2023 20:19
@RainofTerra RainofTerra requested a review from a team as a code owner July 19, 2023 20:19
@RainofTerra RainofTerra changed the title refinery_rules documentation update docs: refinery_rules.md Jul 19, 2023
@mjingle
Copy link
Contributor

mjingle commented Jul 19, 2023

@kentquirk I would be down for modifying the generated docs template to incorporate @RainofTerra's suggestions! :)

@@ -7,7 +7,8 @@ It was automatically generated {{ now }}.
## The Rules file

The rules file is a YAML file.
Here is a simple example of a rules file:
Below is a simple example of a `rules` file.
View a [complete example](https://github.com/honeycombio/refinery/blob/main/rules_complete.yaml).
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@kentquirk Not sure if the templates can support markdown format for links or not... Is this possible or what should be used instead?

Terra Field and others added 6 commits July 31, 2023 22:52
Signed-off-by: Mary Jinglewski <maryjinglewski@honeycomb.io>
Signed-off-by: Mary Jinglewski <maryjinglewski@honeycomb.io>
Signed-off-by: Mary Jinglewski <maryjinglewski@honeycomb.io>
@kentquirk kentquirk force-pushed the terra.rules_doc_update branch from b79b9ff to 263b5b7 Compare August 1, 2023 15:29
@kentquirk kentquirk merged commit f2fa512 into main Aug 1, 2023
@kentquirk kentquirk deleted the terra.rules_doc_update branch August 1, 2023 20:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

docs: The generated docs for rules don't include the options for choices types
3 participants