Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: add missing metrics fields #811

Merged
merged 3 commits into from
Aug 1, 2023
Merged

fix: add missing metrics fields #811

merged 3 commits into from
Aug 1, 2023

Conversation

kentquirk
Copy link
Contributor

Which problem is this PR solving?

Short description of the changes

  • Add mechanism that adds the dynamic fields to otel.
  • Add some histograms for aggregate sample rate and kept sample rate.

@kentquirk kentquirk requested a review from a team as a code owner July 31, 2023 15:54
TylerHelmuth
TylerHelmuth reviewed Jul 31, 2023
View reviewed changes
metrics/otel_metrics.go Show resolved Hide resolved
metrics/otel_metrics.go Show resolved Hide resolved
fchikwekwe
fchikwekwe reviewed Jul 31, 2023
View reviewed changes
Copy link
Contributor

@fchikwekwe fchikwekwe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a clarifying question. Looks good otherwise.

metrics/otel_metrics.go Outdated Show resolved Hide resolved
metrics/otel_metrics.go Show resolved Hide resolved
@kentquirk kentquirk changed the title Kent.801 fix: add missing metrics fields Jul 31, 2023
@kentquirk kentquirk merged commit b03e142 into main Aug 1, 2023
@kentquirk kentquirk deleted the kent.801 branch August 1, 2023 02:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@TylerHelmuth TylerHelmuth TylerHelmuth approved these changes

@fchikwekwe fchikwekwe Awaiting requested review from fchikwekwe

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

OTel metrics is missing a few fields
3 participants
@kentquirk @TylerHelmuth @fchikwekwe