Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Change default ConfigReloadInterval, add jitter, fix docs #823

Merged
merged 1 commit into from
Aug 2, 2023

Conversation

kentquirk
Copy link
Contributor

Which problem is this PR solving?

  • The default config reload interval was too long, and the documentation for it was wrong.

Short description of the changes

  • Change default for config reload to 15s from 5m. The original intent (see Allow peers to gossip news of a new config #725) was to have a fleet of refineries gossiping news of new configs, but that's tricky to get right and probably not needed, especially since for now at least, almost all installations will be using a config file, not a config url.
  • Add a random jitter to avoid thundering herds.
  • Update metadata to explain what it's really doing
  • Regenerate documentation.

@kentquirk kentquirk requested a review from a team as a code owner August 2, 2023 02:52
@kentquirk kentquirk added this to the v2.1 milestone Aug 2, 2023
@kentquirk kentquirk force-pushed the kent.config_reload branch from 8a4b599 to d3507c5 Compare August 2, 2023 02:53
Copy link
Contributor

@TylerHelmuth TylerHelmuth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@kentquirk once this is merged can you open an issue for the helm chart so we remember to update the default values.yaml to set this to 0s?

@kentquirk kentquirk merged commit 4d3a459 into main Aug 2, 2023
@kentquirk kentquirk deleted the kent.config_reload branch August 2, 2023 22:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants