Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Record why a trace was sent #828

Merged
merged 1 commit into from
Aug 3, 2023
Merged

feat: Record why a trace was sent #828

merged 1 commit into from
Aug 3, 2023

Conversation

kentquirk
Copy link
Contributor

@kentquirk kentquirk commented Aug 2, 2023 •
edited
Loading

Which problem is this PR solving?

Short description of the changes

  • Record the name of the metric we increment on trace decisions in a meta field, only when AddRuleReasonToTrace is specified.
  • Update docs
  • Regen docs

@kentquirk kentquirk requested a review from a team as a code owner August 2, 2023 23:33
@kentquirk kentquirk changed the title feat:Record why a trace was sent feat: Record why a trace was sent Aug 2, 2023
@kentquirk kentquirk added this to the v2.1 milestone Aug 2, 2023
@kentquirk kentquirk merged commit 2768278 into main Aug 3, 2023
@kentquirk kentquirk deleted the kent.send_reason branch August 3, 2023 14:46
@kentquirk kentquirk mentioned this pull request Aug 3, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@TylerHelmuth TylerHelmuth TylerHelmuth approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
v2.1
Development

Successfully merging this pull request may close these issues.
2 participants
@kentquirk @TylerHelmuth