Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: add refinery version to refinery metric and log #899

Merged
merged 1 commit into from
Nov 13, 2023
Merged

fix: add refinery version to refinery metric and log #899

merged 1 commit into from
Nov 13, 2023

Conversation

VinozzZ
Copy link
Contributor

@VinozzZ VinozzZ commented Nov 13, 2023

Which problem is this PR solving?

Short description of the changes

This PR adds refinery_version to both legacy metrics and honeycomb logger.

Example of the newly added field:

Screenshot 2023-11-13 at 2 15 37 PM
Screenshot 2023-11-13 at 2 15 13 PM

@VinozzZ VinozzZ requested a review from a team as a code owner November 13, 2023 19:16
kentquirk
kentquirk approved these changes Nov 13, 2023
View reviewed changes
Copy link
Contributor

@kentquirk kentquirk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@VinozzZ VinozzZ merged commit 0db9133 into main Nov 13, 2023
@VinozzZ VinozzZ deleted the yingrong.add_refinery_version_to_telemetry branch November 13, 2023 22:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kentquirk kentquirk kentquirk approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@VinozzZ @kentquirk