Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

maint: update hashicorp/golang-lru #909

Merged
merged 1 commit into from
Nov 29, 2023
Merged

maint: update hashicorp/golang-lru #909

merged 1 commit into from
Nov 29, 2023

Conversation

kentquirk
Copy link
Contributor

Which problem is this PR solving?

  • github.com/hashicorp/golang-lru was updated to v2, now with generics.

Short description of the changes

  • Update dep to v2
  • Fix the code to use the right types
  • Update licenses

This depends on #908 which should be merged first.

@kentquirk kentquirk requested a review from a team as a November 29, 2023 16:46
@kentquirk kentquirk mentioned this pull request Nov 29, 2023
Closed
3 tasks
VinozzZ
VinozzZ approved these changes Nov 29, 2023
View reviewed changes
Copy link
Contributor

@VinozzZ VinozzZ left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Just for my own curiosity, how do we maintain the LICENSES folder? If there's a doc, do you mind to point me to the doc?

Base automatically changed from kent.update_exp to main November 29, 2023 18:45
@kentquirk
Copy link
Contributor Author

You run make update-licenses from the root of the repository.

@kentquirk kentquirk merged commit 17b828e into main Nov 29, 2023
3 checks passed
@kentquirk kentquirk deleted the kent.update_lru branch November 29, 2023 19:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@VinozzZ VinozzZ VinozzZ approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@kentquirk @VinozzZ