maint: attempt to fix flaky integration tests #945
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kentquirk
approved these changes
Dec 13, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which problem is this PR solving?
Since sending a trace is an asynchronous operation, there's a race condition between the writes from libhoney to the transmission buffer and the reads issued from our tests into the buffer.
Short description of the changes
This PR changes tests to use
transmission.MockSenderinstead. The mock sender uses a slice instead of an io.Writer as the buffer. This allows us to avoid race condition between reads and writes.I also added a wait after sending the roundtrip request to make sure Refinery has a chance to flush its in-memory trace cache before we try to validate the sent trace.