Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[enhancement] #1

Closed
bzzbzzz opened this issue Apr 4, 2013 · 11 comments
Closed

[enhancement] #1

bzzbzzz opened this issue Apr 4, 2013 · 11 comments

Comments

@bzzbzzz
Copy link

bzzbzzz commented Apr 4, 2013

support for optionally adding tags to the saved url (via alfred) would be awesome !

@honnix
Copy link
Owner

honnix commented Apr 4, 2013

Sounds good.

How would you like to put tags? Something like pocket <url> <tags separated by comma>?

@bzzbzzz
Copy link
Author

bzzbzzz commented Apr 5, 2013

yes, would be great !

@honnix
Copy link
Owner

honnix commented Apr 5, 2013

good.

Best regards,
Hongxin Liang

On W14, Friday, April 5, 2013 at 10:29 AM, bzzbzzz wrote:

yes, exactly !


Reply to this email directly or view it on GitHub (#1 (comment)).

@bzzbzzz
Copy link
Author

bzzbzzz commented Apr 5, 2013

An option to get the current URL from Safari instead of pasting it would be great too!

if that's not something you'd consider, and if someone else wants something like that:
i use a separate workflow with keyword "safpocket" (and a hotkey) to launch your workflow

on alfred_script(q)

--set theTags to " " & q
tell application "Safari" to set argForDropInPocket to URL of front document -- & theTags
tell application "Alfred 2" to search "pocket" & " " & argForDropInPocket

end alfred_script

if honnix considers to add support for tags: just delete the comments.

Please consider this as constructive criticism for a awesome workflow / extension ! (honnix / david ferguson) I'm not just complaining around and expecting everyone to do what I want :)

@honnix
Copy link
Owner

honnix commented Apr 5, 2013

This is cool!

I will add tag feature but I would rather keep this Safari thing as a separated workflow instead of integrating into the pocket workflow David created.

If you don't mind, I can put the script you provided into README, then people might have their own tweaks maybe towards Chrome for example. :)

Best regards,
Hongxin Liang

On W14, Friday, April 5, 2013 at 11:10 AM, bzzbzzz wrote:

An option to get the current URL from Safari instead of pasting it would be great too!
if that's not something you'd consider, and if someone else wants something like that:
i use a separate workflow with keyword "safpocket" (and a hotkey) to launch your workflow
on alfred_script(q)
--set theTags to " " & q tell application "Safari" to set argForDropInPocket to URL of front document -- & theTags tell application "Alfred 2" to search "pocket" & " " & argForDropInPocket
end alfred_script
if honnix considers to add support for tags: just delete the comments.
Please consider this as constructive criticism for a awesome workflow / extension ! (honnix / david ferguson) I'm not just complaining around and expecting everyone to do what I want :)


Reply to this email directly or view it on GitHub (#1 (comment)).

@bzzbzzz
Copy link
Author

bzzbzzz commented Apr 5, 2013

Safari: What I meant was a different keyword / hotkey in the same workflow to avoid showing the the url (in most cases way too long for the small alfred "window"), but I completely understand.

readme: i don't mind at all, share whatever seems helpful !
here is "how i use your workflow" (safari + clipboard + selection)
feel free to share it as well, (link or workflow file, I just can't guarantee how long I keep it in my temp folder inside dropbox)
https://www.dropbox.com/s/9i5j0szz3hbvs0q/DropInPocket%2BSafari%2BSelection%2BClipboard.alfredworkflow

@honnix
Copy link
Owner

honnix commented Apr 5, 2013

Hmm, this becomes interesting. This workflow still uses v2 api which does not support tag. I need to migrate to v3, and in that case not sure whether the auth program still works.

Best regards,
Hongxin Liang

On W14, Friday, April 5, 2013 at 12:02 PM, bzzbzzz wrote:

Safari: What I meant was different keyword / hotkey in the same workflow to avoid showing the the url (in most cases way too long for the small alfred "window"), but I completely understand.
readme: i don't mind at all, share whatever seems helpful !
here is "how i use your workflow" (safari + clipboard + selection)
feel free to share it as well, (link or workflow file, I just can't guarantee how long I keep it in my temp folder inside dropbox)
https://www.dropbox.com/s/9i5j0szz3hbvs0q/DropInPocket%2BSafari%2BSelection%2BClipboard.alfredworkflow


Reply to this email directly or view it on GitHub (#1 (comment)).

@honnix
Copy link
Owner

honnix commented Apr 5, 2013

  • Migrated to v3 api
  • Solve redirected_uri in a very nasty way
  • add tags support

@honnix honnix closed this as completed Apr 5, 2013
@bzzbzzz
Copy link
Author

bzzbzzz commented Apr 5, 2013

awesome ! updated my forwarding workflow. forwards urls from clipboard, selection or safari depending on hotkey, adds a space after the url to input tags and has an icon now
same url https://www.dropbox.com/s/9i5j0szz3hbvs0q/DropInPocket%2BSafari%2BSelection%2BClipboard.alfredworkflow

@tzarskyz
Copy link

tzarskyz commented Apr 5, 2013

I know this is closed. I just want to confirm that this works great and thank the both of you for putting this code up on github for the rest of us.

I've been dying to get this workflow to grab safari's url with tags support and finally a working solution!!

Much appreciated.

@Rwadxvv
Copy link

Rwadxvv commented Nov 27, 2022

yes, would be great !

Shall

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants