refactor(secure-headers): refine secureHeadersNonce init (#3535)

honojs · Oct 22, 2024 · 15938b4 · 15938b4
1 parent f8664b0
commit 15938b4
Showing 1 changed file with 6 additions and 7 deletions.
diff --git a/src/middleware/secure-headers/secure-headers.ts b/src/middleware/secure-headers/secure-headers.ts
@@ -132,13 +132,12 @@ const generateNonce = () => {
 }
 
 export const NONCE: ContentSecurityPolicyOptionHandler = (ctx) => {
-  const nonce =
-    ctx.get('secureHeadersNonce') ||
-    (() => {
-      const newNonce = generateNonce()
-      ctx.set('secureHeadersNonce', newNonce)
-      return newNonce
-    })()
+  const key = 'secureHeadersNonce'
+  const init = ctx.get(key)
+  const nonce = init || generateNonce()
+  if (init == null) {
+    ctx.set(key, nonce)
+  }
   return `'nonce-${nonce}'`
 }