fix(client): Remove trailing slash from /index for precise path match…

…ing (#2344)
honojs · Mar 13, 2024 · 25beca8 · 25beca8
1 parent 76864b4
commit 25beca8
Show file tree

Hide file tree

Showing 3 changed files with 6 additions and 6 deletions.
diff --git a/deno_dist/client/utils.ts b/deno_dist/client/utils.ts
@@ -16,7 +16,7 @@ export const replaceUrlParam = (urlString: string, params: Record<string, string
 }
 
 export const removeIndexString = (urlSting: string) => {
-  return urlSting.replace(/\/index$/, '/')
+  return urlSting.replace(/\/index$/, '')
 }
 
 function isObject(item: unknown): item is ObjectType {

diff --git a/src/client/utils.test.ts b/src/client/utils.test.ts
@@ -43,18 +43,18 @@ describe('replaceUrlParams', () => {
 })
 
 describe('removeIndexString', () => {
-  it('Should remove last `index` string', () => {
+  it('Should remove last `/index` string', () => {
     let url = 'http://localhost/index'
     let newUrl = removeIndexString(url)
-    expect(newUrl).toBe('http://localhost/')
+    expect(newUrl).toBe('http://localhost')
 
     url = '/index'
     newUrl = removeIndexString(url)
-    expect(newUrl).toBe('/')
+    expect(newUrl).toBe('')
 
     url = '/sub/index'
     newUrl = removeIndexString(url)
-    expect(newUrl).toBe('/sub/')
+    expect(newUrl).toBe('/sub')
 
     url = '/subindex'
     newUrl = removeIndexString(url)

diff --git a/src/client/utils.ts b/src/client/utils.ts
@@ -16,7 +16,7 @@ export const replaceUrlParam = (urlString: string, params: Record<string, string
 }
 
 export const removeIndexString = (urlSting: string) => {
-  return urlSting.replace(/\/index$/, '/')
+  return urlSting.replace(/\/index$/, '')
 }
 
 function isObject(item: unknown): item is ObjectType {