fix(jsx): changes behavior when download attribute is set to a bool…

…ean value (#3094)

src/jsx/base.ts

@@ -56,6 +56,7 @@ const booleanAttributes = [
   'default',
   'defer',
   'disabled',
+  'download',
   'formnovalidate',
   'hidden',
   'inert',

src/jsx/index.test.tsx

@@ -297,6 +297,28 @@ describe('render to string', () => {
     })
   })
 
+  describe('download attribute', () => {
+    it('<a download={true}></a> should be rendered as <a download=""></a>', () => {
+      const template = <a download={true}></a>
+      expect(template.toString()).toBe('<a download=""></a>')
+    })
+
+    it('<a download={false}></a> should be rendered as <a></a>', () => {
+      const template = <a download={false}></a>
+      expect(template.toString()).toBe('<a></a>')
+    })
+
+    it('<a download></a> should be rendered as <a download=""></a>', () => {
+      const template = <a download></a>
+      expect(template.toString()).toBe('<a download=""></a>')
+    })
+
+    it('<a download="test"></a> should be rendered as <a download="test"></a>', () => {
+      const template = <a download='test'></a>
+      expect(template.toString()).toBe('<a download="test"></a>')
+    })
+  })
+
   describe('Function', () => {
     it('should be ignored used in on* props', () => {
       const onClick = () => {}

src/jsx/intrinsic-elements.ts

@@ -179,7 +179,7 @@ export namespace JSX {
   type HTMLAttributeAnchorTarget = '_self' | '_blank' | '_parent' | '_top' | string
 
   interface AnchorHTMLAttributes extends HTMLAttributes {
-    download?: any
+    download?: string | boolean | undefined
     href?: string | undefined
     hreflang?: string | undefined
     media?: string | undefined
@@ -194,7 +194,7 @@ export namespace JSX {
   interface AreaHTMLAttributes extends HTMLAttributes {
     alt?: string | undefined
     coords?: string | undefined
-    download?: any
+    download?: string | boolean | undefined
     href?: string | undefined
     hreflang?: string | undefined
     media?: string | undefined