fix(sse): Handler stuck when awaiting aborted SSE stream (#2273)

* cancel internal stream reader on responseReadable abort * run denoify
honojs · Feb 27, 2024 · a3d9f13 · a3d9f13
1 parent d7b1fe8
commit a3d9f13
Show file tree

Hide file tree

Showing 2 changed files with 14 additions and 0 deletions.
diff --git a/deno_dist/utils/stream.ts b/deno_dist/utils/stream.ts
@@ -12,6 +12,13 @@ export class StreamingApi {
 
     const reader = _readable.getReader()
 
+    // in case the user disconnects, let the reader know to cancel
+    // this in-turn results in responseReadable being closed
+    // and writeSSE method no longer blocks indefinitely
+    this.abortSubscribers.push(async () => {
+      await reader.cancel()
+    })
+
     this.responseReadable = new ReadableStream({
       async pull(controller) {
         const { done, value } = await reader.read()

diff --git a/src/utils/stream.ts b/src/utils/stream.ts
@@ -12,6 +12,13 @@ export class StreamingApi {
 
     const reader = _readable.getReader()
 
+    // in case the user disconnects, let the reader know to cancel
+    // this in-turn results in responseReadable being closed
+    // and writeSSE method no longer blocks indefinitely
+    this.abortSubscribers.push(async () => {
+      await reader.cancel()
+    })
+
     this.responseReadable = new ReadableStream({
       async pull(controller) {
         const { done, value } = await reader.read()