fix(factory): correct types inside of createMiddleware() (#2081)

* fix(factory): correct types inside of `createMiddleware()` * denoify
honojs · Jan 25, 2024 · b23cf8d · b23cf8d
1 parent 4ec3a9b
commit b23cf8d
Show file tree

Hide file tree

Showing 3 changed files with 4 additions and 3 deletions.
diff --git a/deno_dist/helper/factory/index.ts b/deno_dist/helper/factory/index.ts
@@ -270,5 +270,5 @@ export class Factory<E extends Env = any, P extends string = any> {
 export const createFactory = <E extends Env = any, P extends string = any>() => new Factory<E, P>()
 
 export const createMiddleware = <E extends Env = any, P extends string = any, I extends Input = {}>(
-  middleware: MiddlewareHandler
+  middleware: MiddlewareHandler<E, P, I>
 ) => createFactory<E, P>().createMiddleware<I>(middleware)
diff --git a/src/helper/factory/index.test.ts b/src/helper/factory/index.test.ts
@@ -8,10 +8,11 @@ import { createMiddleware, createFactory } from './index'
 
 describe('createMiddleware', () => {
   type Env = { Variables: { foo: string } }
-  const app = new Hono<Env>()
+  const app = new Hono()
 
   const mw = (message: string) =>
     createMiddleware<Env>(async (c, next) => {
+      expectTypeOf(c.var.foo).toEqualTypeOf<string>()
       c.set('foo', 'bar')
       await next()
       c.header('X-Message', message)

diff --git a/src/helper/factory/index.ts b/src/helper/factory/index.ts
@@ -270,5 +270,5 @@ export class Factory<E extends Env = any, P extends string = any> {
 export const createFactory = <E extends Env = any, P extends string = any>() => new Factory<E, P>()
 
 export const createMiddleware = <E extends Env = any, P extends string = any, I extends Input = {}>(
-  middleware: MiddlewareHandler
+  middleware: MiddlewareHandler<E, P, I>
 ) => createFactory<E, P>().createMiddleware<I>(middleware)