-
-
Notifications
You must be signed in to change notification settings - Fork 619
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(jwt): Use Signed Cookie in JWT Middleware #2989
feat(jwt): Use Signed Cookie in JWT Middleware #2989
Conversation
Adds support for getSignedCookie while also allowing for all options to getCookie/getSignedCookie to be set.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #2989 +/- ##
==========================================
+ Coverage 94.75% 95.86% +1.11%
==========================================
Files 136 137 +1
Lines 13339 13421 +82
Branches 2240 2267 +27
==========================================
+ Hits 12639 12866 +227
+ Misses 700 555 -145 ☔ View full report in Codecov by Sentry. |
HI @newarifrh Thank you for the PR. Could you add tests not to take down the test coverage? |
Hi @yusukebe, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
Looks good to me! I'll merge this into the |
Continuing from #2403 & fixing for #2398 where there was no update, and slightly fixed the use/non-use of prefixOptions
The author should do the following, if applicable
bun run format:fix && bun run lint:fix
to format the code