Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(jwt): Use Signed Cookie in JWT Middleware #2989

Merged

Conversation

newarifrh
Copy link
Contributor

@newarifrh newarifrh commented Jun 18, 2024

Continuing from #2403 & fixing for #2398 where there was no update, and slightly fixed the use/non-use of prefixOptions

The author should do the following, if applicable

  • Add tests
  • Run tests
  • bun run format:fix && bun run lint:fix to format the code
  • Add TSDoc/JSDoc to document the code

Copy link

codecov bot commented Jun 23, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 95.86%. Comparing base (b9799e4) to head (6e287e5).
Report is 12 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2989      +/-   ##
==========================================
+ Coverage   94.75%   95.86%   +1.11%     
==========================================
  Files         136      137       +1     
  Lines       13339    13421      +82     
  Branches     2240     2267      +27     
==========================================
+ Hits        12639    12866     +227     
+ Misses        700      555     -145     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@yusukebe
Copy link
Member

HI @newarifrh

Thank you for the PR. Could you add tests not to take down the test coverage?

@newarifrh
Copy link
Contributor Author

HI @newarifrh

Thank you for the PR. Could you add tests not to take down the test coverage?

Hi @yusukebe,
I just added a few tests for codes that have not been covered

@yusukebe yusukebe changed the base branch from main to next June 27, 2024 01:07
@yusukebe yusukebe changed the base branch from next to main June 27, 2024 01:08
@yusukebe yusukebe changed the base branch from main to next June 27, 2024 01:12
Copy link
Member

@yusukebe yusukebe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@yusukebe
Copy link
Member

@newarifrh

Looks good to me! I'll merge this into the next branch for the next minor version, v4.5.0 now. It will be released during July. Thank you!

@yusukebe yusukebe merged commit 936db9b into honojs:next Jun 27, 2024
14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants