Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(vercel): add getConnInfo for vercel adapter #3085

Merged
merged 1 commit into from
Jul 8, 2024

Conversation

promer94
Copy link
Contributor

@promer94 promer94 commented Jul 3, 2024

This pr adds getConnInfo for vercel adapter based on https://github.com/vercel/vercel/blob/b70bfb5fbf28a4650d4042ce68ca5c636d37cf44/packages/edge/src/edge-headers.ts#L10-L12C32

The author should do the following, if applicable

  • Add tests
  • Run tests
  • bun run format:fix && bun run lint:fix to format the code
  • Add TSDoc/JSDoc to document the code

promer94 added a commit to promer94/hono-website that referenced this pull request Jul 3, 2024
Copy link

codecov bot commented Jul 4, 2024

Codecov Report

Attention: Patch coverage is 90.00000% with 1 line in your changes missing coverage. Please review.

Project coverage is 95.87%. Comparing base (75c314c) to head (d44be38).
Report is 1 commits behind head on main.

Files Patch % Lines
src/adapter/vercel/index.ts 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3085      +/-   ##
==========================================
- Coverage   95.88%   95.87%   -0.01%     
==========================================
  Files         137      138       +1     
  Lines       13475    13485      +10     
  Branches     2384     2359      -25     
==========================================
+ Hits        12920    12929       +9     
- Misses        555      556       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@yusukebe yusukebe added the v4.5 label Jul 4, 2024
@yusukebe yusukebe changed the base branch from main to next July 8, 2024 14:31
Copy link
Member

@yusukebe yusukebe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@yusukebe
Copy link
Member

yusukebe commented Jul 8, 2024

Hi @promer94 !

Sorry for my late reply. Looks good! I'll merge this into the next branch and release the next minor version, 4.5.0, which includes this feature soon! Thanks!

@yusukebe yusukebe merged commit ce1c817 into honojs:next Jul 8, 2024
14 checks passed
@promer94 promer94 deleted the feat/vercel-ConnInfo branch July 8, 2024 19:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants