Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(jsx): allow to merge CSSProperties declaration #3228

Merged

Conversation

jonasnobile
Copy link
Contributor

Type declarations don't allow to merge, so overriding type declaration from docs doesn't work for CSSProperties.

The author should do the following, if applicable

  • Add tests
  • Run tests
  • bun run format:fix && bun run lint:fix to format the code
  • Add TSDoc/JSDoc to document the code

@yusukebe
Copy link
Member

yusukebe commented Aug 4, 2024

Hi @jonasnobile

Nice! This is a good improvement. One thing: can you run bun run format:fix && bun run lint:fix to fixe the format?

Copy link

codecov bot commented Aug 6, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 96.21%. Comparing base (1fafc7a) to head (d68d109).
Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff            @@
##             main    #3228    +/-   ##
========================================
  Coverage   96.21%   96.21%            
========================================
  Files         151      151            
  Lines       15096    15096            
  Branches     2620     2756   +136     
========================================
  Hits        14524    14524            
  Misses        572      572            

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@yusukebe
Copy link
Member

yusukebe commented Aug 6, 2024

Hi @jonasnobile

I've fixed the format myself. I'll merge this now. Thank you for your contribution!

@yusukebe yusukebe merged commit e42795c into honojs:main Aug 6, 2024
14 checks passed
@jonasnobile
Copy link
Contributor Author

Hi @yusukebe,

Sorry, I've missed this one. Thanks for fixing formatting and merging it.

adamnolte referenced this pull request in autoblocksai/cli Aug 9, 2024
[![Mend
Renovate](https://app.renovatebot.com/images/banner.svg)](https://renovatebot.com)

This PR contains the following updates:

| Package | Change | Age | Adoption | Passing | Confidence |
|---|---|---|---|---|---|
| [hono](https://hono.dev/) ([source](https://github.com/honojs/hono))
| [`4.5.1` ->
`4.5.4`](https://renovatebot.com/diffs/npm/hono/4.5.1/4.5.4) |
[![age](https://developer.mend.io/api/mc/badges/age/npm/hono/4.5.4?slim=true)](https://docs.renovatebot.com/merge-confidence/)
|
[![adoption](https://developer.mend.io/api/mc/badges/adoption/npm/hono/4.5.4?slim=true)](https://docs.renovatebot.com/merge-confidence/)
|
[![passing](https://developer.mend.io/api/mc/badges/compatibility/npm/hono/4.5.1/4.5.4?slim=true)](https://docs.renovatebot.com/merge-confidence/)
|
[![confidence](https://developer.mend.io/api/mc/badges/confidence/npm/hono/4.5.1/4.5.4?slim=true)](https://docs.renovatebot.com/merge-confidence/)
|

---

### Release Notes

<details>
<summary>honojs/hono (hono)</summary>

### [`v4.5.4`](https://github.com/honojs/hono/releases/tag/v4.5.4)

[Compare
Source](https://github.com/honojs/hono/compare/v4.5.3...v4.5.4)

##### What's Changed

- fix(jsx): corrects the type of 'draggable' attribute in
intrinsic-elements.ts by
[@&#8203;yasuaki640](https://github.com/yasuaki640) in
[https://github.com/honojs/hono/pull/3224](https://github.com/honojs/hono/pull/3224)
- feat(jsx): allow to merge CSSProperties declaration by
[@&#8203;jonasnobile](https://github.com/jonasnobile) in
[https://github.com/honojs/hono/pull/3228](https://github.com/honojs/hono/pull/3228)
- feat(client): Add WebSocket Provider Integration Tests and Enhance
WebSocket Initialization by
[@&#8203;naporin0624](https://github.com/naporin0624) in
[https://github.com/honojs/hono/pull/3213](https://github.com/honojs/hono/pull/3213)
- fix(types): `param` in `ValidationTargets` supports optional param by
[@&#8203;yusukebe](https://github.com/yusukebe) in
[https://github.com/honojs/hono/pull/3229](https://github.com/honojs/hono/pull/3229)

##### New Contributors

- [@&#8203;jonasnobile](https://github.com/jonasnobile) made their
first contribution in
[https://github.com/honojs/hono/pull/3228](https://github.com/honojs/hono/pull/3228)

**Full Changelog**:
honojs/hono@v4.5.3...v4.5.4

### [`v4.5.3`](https://github.com/honojs/hono/releases/tag/v4.5.3)

[Compare
Source](https://github.com/honojs/hono/compare/v4.5.2...v4.5.3)

#### What's Changed

- fix(validator): Add double quotation marks to multipart checker regex
by [@&#8203;CPlusPatch](https://github.com/CPlusPatch) in
[https://github.com/honojs/hono/pull/3195](https://github.com/honojs/hono/pull/3195)
- fix(validator): support `application/json` with a charset as JSON by
[@&#8203;yusukebe](https://github.com/yusukebe) in
[https://github.com/honojs/hono/pull/3199](https://github.com/honojs/hono/pull/3199)
- fix(jsx): fix handling of SVG elements in JSX. by
[@&#8203;usualoma](https://github.com/usualoma) in
[https://github.com/honojs/hono/pull/3204](https://github.com/honojs/hono/pull/3204)
- fix(jsx/dom): fix performance issue with adding many new node listings
by [@&#8203;usualoma](https://github.com/usualoma) in
[https://github.com/honojs/hono/pull/3205](https://github.com/honojs/hono/pull/3205)
- fix(service-worker): refer to `self.fetch` correctly by
[@&#8203;yusukebe](https://github.com/yusukebe) in
[https://github.com/honojs/hono/pull/3200](https://github.com/honojs/hono/pull/3200)

#### New Contributors

- [@&#8203;CPlusPatch](https://github.com/CPlusPatch) made their first
contribution in
[https://github.com/honojs/hono/pull/3195](https://github.com/honojs/hono/pull/3195)

**Full Changelog**:
honojs/hono@v4.5.2...v4.5.3

### [`v4.5.2`](https://github.com/honojs/hono/releases/tag/v4.5.2)

[Compare
Source](https://github.com/honojs/hono/compare/v4.5.1...v4.5.2)

#### What's Changed

- fix(helper/adapter): don't check `navigator` is `undefined` by
[@&#8203;yusukebe](https://github.com/yusukebe) in
[https://github.com/honojs/hono/pull/3171](https://github.com/honojs/hono/pull/3171)
- fix(types): handle readonly array correctly by
[@&#8203;m-shaka](https://github.com/m-shaka) in
[https://github.com/honojs/hono/pull/3172](https://github.com/honojs/hono/pull/3172)
- Revert "fix(helper/adapter): don't check `navigator` is `undefined` by
[@&#8203;yusukebe](https://github.com/yusukebe) in
[https://github.com/honojs/hono/pull/3173](https://github.com/honojs/hono/pull/3173)
- fix(type): degradation of generic type handling by
[@&#8203;m-shaka](https://github.com/m-shaka) in
[https://github.com/honojs/hono/pull/3138](https://github.com/honojs/hono/pull/3138)
- fix:(csrf) fix typo of csrf middleware by
[@&#8203;yasuaki640](https://github.com/yasuaki640) in
[https://github.com/honojs/hono/pull/3178](https://github.com/honojs/hono/pull/3178)
- feat(secure-headers): remove "X-Powered-By" should be an option by
[@&#8203;EdamAme-x](https://github.com/EdamAme-x) in
[https://github.com/honojs/hono/pull/3177](https://github.com/honojs/hono/pull/3177)

**Full Changelog**:
honojs/hono@v4.5.1...v4.5.2

</details>

---

### Configuration

📅 **Schedule**: Branch creation - "before 4am on Monday" in timezone
America/Chicago, Automerge - At any time (no schedule defined).

🚦 **Automerge**: Disabled by config. Please merge this manually once you
are satisfied.

♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the
rebase/retry checkbox.

🔕 **Ignore**: Close this PR and you won't be reminded about this update
again.

---

- [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check
this box

---

This PR was generated by [Mend
Renovate](https://www.mend.io/free-developer-tools/renovate/). View the
[repository job log](https://developer.mend.io/github/autoblocksai/cli).

<!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNy40NDAuNyIsInVwZGF0ZWRJblZlciI6IjM4LjE4LjE3IiwidGFyZ2V0QnJhbmNoIjoibWFpbiIsImxhYmVscyI6W119-->

Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
@nsaunders
Copy link

While converting the CSSProperties type alias to an interface is a welcome change, I am curious to know why it was necessary for the style prop to accept a string?

@EdamAme-x
Copy link
Contributor

I'm not a specialist, but I'm sure it's not a problem in terms of compatibility.
Some properties can be used in a different direction than React.

@jonasnobile
Copy link
Contributor Author

@nsaunders CSS properties could always be written as strings since {} inherently allows that. The change simply improves the typing when you choose to write styles as an object.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants