Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(jsx): improve a-tag types with well known values #3287

Merged
merged 2 commits into from
Aug 19, 2024
Merged

feat(jsx): improve a-tag types with well known values #3287

merged 2 commits into from
Aug 19, 2024

Conversation

ssssota
Copy link
Contributor

@ssssota ssssota commented Aug 17, 2024

ref. #3276

image
image

The author should do the following, if applicable

  • Add tests
  • Run tests
  • bun run format:fix && bun run lint:fix to format the code
  • Add TSDoc/JSDoc to document the code

@ssssota
Copy link
Contributor Author

ssssota commented Aug 17, 2024

Should I separate pull requests, refactoring and feature?

@codecov Codecov
Copy link

codecov bot commented Aug 17, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 96.20%. Comparing base (8f16802) to head (0efc03f).
Report is 3 commits behind head on main.

Additional details and impacted files 
@@           Coverage Diff            @@
##             main    #3287    +/-   ##
========================================
  Coverage   96.20%   96.20%            
========================================
  Files         151      151            
  Lines       15293    15293            
  Branches     2761     2631   -130     
========================================
  Hits        14713    14713            
  Misses        580      580

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

ssssota
ssssota commented Aug 17, 2024
View reviewed changes
src/jsx/intrinsic-elements.ts
@@ -199,7 +202,7 @@ export namespace JSX {
| 'strict-origin-when-cross-origin'
| 'unsafe-url'

type HTMLAttributeAnchorTarget = '_self' | '_blank' | '_parent' | '_top' | string
type HTMLAttributeAnchorTarget = StringLiteralUnion<'_self' | '_blank' | '_parent' | '_top'>
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Which do you like better this or the above:

  type HTMLAttributeAnchorTarget = '_self' | '_blank' | '_parent' | '_top'
//...
  StringLiteralUnion<HTMLAttributeAnchorTarget>

I reffered to DefinitelyTyped/DefinitelyTyped@462531a .

yusukebe
yusukebe approved these changes Aug 19, 2024
View reviewed changes
Copy link
Member

@yusukebe yusukebe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@yusukebe
Copy link
Member

@ssssota

Super cool!

You don't have to separate the PR. Let's go with it. Thank you!

@yusukebe yusukebe merged commit 17c3b9e into honojs:main Aug 19, 2024
14 checks passed
@ssssota ssssota deleted the feat/improve-a-tag-types branch August 19, 2024 01:21
adamnolte referenced this pull request in autoblocksai/cli Aug 22, 2024
@renovate
Update dependency hono to v4.5.8 [SECURITY] (#130)
9280c6b 
[![Mend
Renovate](https://app.renovatebot.com/images/banner.svg)](https://renovatebot.com)

This PR contains the following updates:

| Package | Change | Age | Adoption | Passing | Confidence |
|---|---|---|---|---|---|
| [hono](https://hono.dev/) ([source](https://github.com/honojs/hono))
| [`4.5.5` ->
`4.5.8`](https://renovatebot.com/diffs/npm/hono/4.5.5/4.5.8) |
[![age](https://developer.mend.io/api/mc/badges/age/npm/hono/4.5.8?slim=true)](https://docs.renovatebot.com/merge-confidence/)
|
[![adoption](https://developer.mend.io/api/mc/badges/adoption/npm/hono/4.5.8?slim=true)](https://docs.renovatebot.com/merge-confidence/)
|
[![passing](https://developer.mend.io/api/mc/badges/compatibility/npm/hono/4.5.5/4.5.8?slim=true)](https://docs.renovatebot.com/merge-confidence/)
|
[![confidence](https://developer.mend.io/api/mc/badges/confidence/npm/hono/4.5.5/4.5.8?slim=true)](https://docs.renovatebot.com/merge-confidence/)
|

### GitHub Vulnerability Alerts

####
[CVE-2024-43787](https://github.com/honojs/hono/security/advisories/GHSA-rpfr-3m35-5vx5)

### Summary

Hono CSRF middleware can be bypassed using crafted Content-Type header.

### Details

MIME types are case insensitive, but `isRequestedByFormElementRe` only
matches lower-case.


https://github.com/honojs/hono/blob/b0af71fbcc6dbe44140ea76f16d68dfdb32a99a0/src/middleware/csrf/index.ts#L16-L17

As a result, attacker can bypass csrf middleware using upper-case
form-like MIME type, such as "Application/x-www-form-urlencoded".

### PoC

```html
<html>
  <head>
    <title>CSRF Test</title>
    <script defer>
      document.addEventListener("DOMContentLoaded", () => {
        document.getElementById("btn").addEventListener("click", async () => {
          const res = await fetch("http://victim.example.com/test", {
            method: "POST",
            credentials: "include",
            headers: {
              "Content-Type": "Application/x-www-form-urlencoded",
            },
          });
        });
      });
    </script>
  </head>
  <body>
    <h1>CSRF Test</h1>
    <button id="btn">Click me!</button>
  </body>
</html>
```

### Impact

Bypass csrf protection implemented with hono csrf middleware.

### Discussion

I'm not sure that omitting csrf checks for Simple POST request is a good
idea.
CSRF prevention and CORS are different concepts even though CORS can
prevent CSRF in some cases.

---

### Release Notes

<details>
<summary>honojs/hono (hono)</summary>

### [`v4.5.8`](https://github.com/honojs/hono/releases/tag/v4.5.8)

[Compare
Source](https://github.com/honojs/hono/compare/v4.5.7...v4.5.8)

##### Security Fix for CSRF Protection Middleware

Before this release, in versions 4.5.7 and below, the CSRF Protection
Middleware did not treat requests including `Content-Types` with
uppercase letters (e.g., `Application/x-www-form-urlencoded`) as
potential attacks, allowing them to pass.

This could cause unexpected behavior, leading to a vulnerability. If you
are using the CSRF Protection Middleware, please upgrade to version
4.5.8 or higher immediately.

For more details, see the report here:
GHSA-rpfr-3m35-5vx5

### [`v4.5.7`](https://github.com/honojs/hono/releases/tag/v4.5.7)

[Compare
Source](https://github.com/honojs/hono/compare/v4.5.6...v4.5.7)

#### What's Changed

- fix(jsx/dom): Fixed a bug that caused Script elements to turn into
Style elements. by [@&#8203;usualoma](https://github.com/usualoma) in
[https://github.com/honojs/hono/pull/3294](https://github.com/honojs/hono/pull/3294)
- perf(jsx/dom): improve performance by
[@&#8203;usualoma](https://github.com/usualoma) in
[https://github.com/honojs/hono/pull/3288](https://github.com/honojs/hono/pull/3288)
- feat(jsx): improve a-tag types with well known values by
[@&#8203;ssssota](https://github.com/ssssota) in
[https://github.com/honojs/hono/pull/3287](https://github.com/honojs/hono/pull/3287)
- fix(validator): Fixed a bug in hono/validator where URL Encoded Data
could not be validated if the Content-Type included charset. by
[@&#8203;uttk](https://github.com/uttk) in
[https://github.com/honojs/hono/pull/3297](https://github.com/honojs/hono/pull/3297)
- feat(jsx): improve `target` and `formtarget` attribute types by
[@&#8203;ssssota](https://github.com/ssssota) in
[https://github.com/honojs/hono/pull/3299](https://github.com/honojs/hono/pull/3299)
- docs(README): change Twitter to X by
[@&#8203;nakasyou](https://github.com/nakasyou) in
[https://github.com/honojs/hono/pull/3301](https://github.com/honojs/hono/pull/3301)
- fix(client): replace optional params to url correctly by
[@&#8203;yusukebe](https://github.com/yusukebe) in
[https://github.com/honojs/hono/pull/3304](https://github.com/honojs/hono/pull/3304)
- feat(jsx): improve input attribute types based on react by
[@&#8203;ssssota](https://github.com/ssssota) in
[https://github.com/honojs/hono/pull/3302](https://github.com/honojs/hono/pull/3302)

#### New Contributors

- [@&#8203;uttk](https://github.com/uttk) made their first
contribution in
[https://github.com/honojs/hono/pull/3297](https://github.com/honojs/hono/pull/3297)

**Full Changelog**:
honojs/hono@v4.5.6...v4.5.7

### [`v4.5.6`](https://github.com/honojs/hono/releases/tag/v4.5.6)

[Compare
Source](https://github.com/honojs/hono/compare/v4.5.5...v4.5.6)

#### What's Changed

- fix(jsx): handle async component error explicitly and throw the error
in the response by [@&#8203;usualoma](https://github.com/usualoma) in
[https://github.com/honojs/hono/pull/3274](https://github.com/honojs/hono/pull/3274)
- fix(validator): support multipart headers without a separating space
by [@&#8203;Ernxst](https://github.com/Ernxst) in
[https://github.com/honojs/hono/pull/3286](https://github.com/honojs/hono/pull/3286)
- fix(validator): Allow form data will mutliple values appended by
[@&#8203;nicksrandall](https://github.com/nicksrandall) in
[https://github.com/honojs/hono/pull/3273](https://github.com/honojs/hono/pull/3273)
- feat(jsx): improve meta-tag types with well known values by
[@&#8203;ssssota](https://github.com/ssssota) in
[https://github.com/honojs/hono/pull/3276](https://github.com/honojs/hono/pull/3276)

#### New Contributors

- [@&#8203;Ernxst](https://github.com/Ernxst) made their first
contribution in
[https://github.com/honojs/hono/pull/3286](https://github.com/honojs/hono/pull/3286)
- [@&#8203;ssssota](https://github.com/ssssota) made their first
contribution in
[https://github.com/honojs/hono/pull/3276](https://github.com/honojs/hono/pull/3276)

**Full Changelog**:
honojs/hono@v4.5.5...v4.5.6

</details>

---

### Configuration

📅 **Schedule**: Branch creation - "" in timezone America/Chicago,
Automerge - At any time (no schedule defined).

🚦 **Automerge**: Disabled by config. Please merge this manually once you
are satisfied.

♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the
rebase/retry checkbox.

🔕 **Ignore**: Close this PR and you won't be reminded about this update
again.

---

- [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check
this box

---

This PR was generated by [Mend
Renovate](https://www.mend.io/free-developer-tools/renovate/). View the
[repository job log](https://developer.mend.io/github/autoblocksai/cli).

<!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzOC4yNi4xIiwidXBkYXRlZEluVmVyIjoiMzguMjYuMSIsInRhcmdldEJyYW5jaCI6Im1haW4iLCJsYWJlbHMiOltdfQ==-->

Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
This was referenced Sep 17, 2024
Closed
Closed
Closed
This was referenced Sep 18, 2024
Open
Open
This was referenced Oct 17, 2024
Open
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yusukebe yusukebe yusukebe approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ssssota @yusukebe