Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(types): useSyncExternalStore type #3437

Merged
merged 1 commit into from
Sep 23, 2024
Merged

fix(types): useSyncExternalStore type #3437

merged 1 commit into from
Sep 23, 2024

Conversation

codehz
Copy link
Contributor

@codehz codehz commented Sep 22, 2024

Align with react
note: the parameter is not used in function body

The author should do the following, if applicable

  • Add tests (I don't how to add type-only test)
  • Run tests (some unrelated test failed)
  • bun run format:fix && bun run lint:fix to format the code
  • Add TSDoc/JSDoc to document the code

Align with react
note: the parameter is not used in function body
@codehz codehz changed the title Fix useSyncExternalStore type fix(types): useSyncExternalStore type Sep 23, 2024
Copy link

codecov bot commented Sep 23, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 95.77%. Comparing base (66df4e1) to head (b8eb249).
Report is 5 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #3437   +/-   ##
=======================================
  Coverage   95.77%   95.77%           
=======================================
  Files         155      155           
  Lines        9310     9310           
  Branches     2759     2720   -39     
=======================================
  Hits         8917     8917           
  Misses        393      393           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@yusukebe yusukebe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@yusukebe
Copy link
Member

@codehz

Thanks! Merging now.

@yusukebe yusukebe merged commit ad0bba0 into honojs:main Sep 23, 2024
16 checks passed
TinsFox pushed a commit to TinsFox/hono that referenced this pull request Oct 28, 2024
Align with react
note: the parameter is not used in function body
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants