Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: use Deno v2 #3506

Merged
merged 5 commits into from
Oct 12, 2024
Merged

ci: use Deno v2 #3506

merged 5 commits into from
Oct 12, 2024

Conversation

yusukebe
Copy link
Member

The author should do the following, if applicable

  • Add tests
  • Run tests
  • bun run format:fix && bun run lint:fix to format the code
  • Add TSDoc/JSDoc to document the code

Copy link

codecov bot commented Oct 11, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 95.58%. Comparing base (04e5897) to head (3385df4).
Report is 3 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #3506   +/-   ##
=======================================
  Coverage   95.58%   95.58%           
=======================================
  Files         155      155           
  Lines        9357     9357           
  Branches     2769     2781   +12     
=======================================
  Hits         8944     8944           
  Misses        413      413           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@yusukebe
Copy link
Member Author

I don't know why the CI is failing at this point:

https://github.com/honojs/hono/actions/runs/11288419552/job/31396151584?pr=3506#step:4:94

I know it's okay to add the deno install—-no-lock command before running deno publish—-dry-run. But is @types/node necessary?

@nakasyou
Copy link
Contributor

I have some idea to resolve it.

First, create deno.json and write

{
  "nodeModulesDir": "auto"
}

and you may resolve this error.

Or, using bunx jsr publish --dry-run instead of deno publish --dry-run might resolve this.

@yusukebe
Copy link
Member Author

@nakasyou Thank you!

Or, using bunx jsr publish --dry-run instead of deno publish --dry-run might resolve this.

I've chosen this method. It works well! You are great!

@yusukebe yusukebe merged commit 9986b47 into main Oct 12, 2024
16 checks passed
@yusukebe yusukebe deleted the ci/deno-2 branch October 12, 2024 05:09
TinsFox pushed a commit to TinsFox/hono that referenced this pull request Oct 28, 2024
* ci: use Deno `v2`

* add `deno install` command

* use `bunx jsr publish --dry-run

* add `oven-sh/setup-bun@v1`
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants