-
Notifications
You must be signed in to change notification settings - Fork 49
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(serve-static): add precompressed
option
#199
Conversation
Hey @usualoma ! Can you review this? |
@@ -199,7 +199,7 @@ app.use( | |||
You can specify handling when the requested file is found with `onFound`. | |||
|
|||
```ts | |||
app.get( | |||
app.use( |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Other examples are using use
.
I'll check it out, just give me a minute. |
Sorry I haven't commented on this at honojs/hono#3366. I think it is a very good feature, but the implementation could use some improvement in my opinion. I have created #200 and would like you to consider merging calling
|
@usualoma Thanks! I'll check it later. |
Hi @usualoma Fully agree with your improvements. Using |
#200) * perf(serve-static): use "Set" for checking precompressed * perf(serve-static): search precompressed file only if content type is compressible
Implemented the same feature of honojs/hono#3366