created serve-static middleware for node #5
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yusukebe
requested changes
Sep 27, 2022
|
And, please write the tests for Serve Static middleware. If there is no test, we will not accept the PR. |
|
I have written the tests and fixed the import from hono. Please review the PR. Thanks! |
|
Also should I update honojs.dev for this middleware? |
yusukebe
reviewed
Sep 29, 2022
|
Hi @that-ambuj ! Nice! I've commented on some points, please fix these.
You don't have to do it now. |
|
Changes have been made! |
yusukebe
requested changes
Sep 29, 2022
|
Two reviews are still pending. |
|
Should I make more changes? |
yusukebe
approved these changes
Sep 29, 2022
|
Nothing! All done! |
|
Thanks a lot for letting me work on this! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It is the serve-static implementation as requested in issue #3. there are no major changes. I have exported both serve and serveStatic from index.ts.