-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Move UltiSnips snippets into vim-snippets. #311
Conversation
@@ -1,5 +1,3 @@ | |||
IMPORTANT: comment on: [What about merging with Ultisnip using its engine](https://github.com/garbas/vim-snipmate/issues/114) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is outdated. UltiSnips is now a drop in replacement for snipMate - merging is in one sense "done" and in one sense "not needed".
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
No Its not, see other comment. Just because you say it doesn't make it true. What might be missing
a) declacative approach
b) selecting the snippet files to us
c) being able to define your own viml function which patches/adds/removes snippets
...
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The discussion is outdated still - there has been made no progress and no decision for months and it seems like we have reached a feature saturation more or less. It is also about engines, not datafiles - most users will not care. I have no problem referencing this someplace else, but not as first line on the top.
After all and finally: SirVer: You're welcome! |
For what? Did I forgot to thank anyone? If so, I apologize, I do not mean to hurt anybody's feelings. |
@@ -1,5 +1,7 @@ | |||
# Credit: @iurifg |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Also about crediting, I don't deserve the credit for these snippets. I just compiled them from https://github.com/carlosgaldino/elixir-snippets with some modifications.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'll remove this line then before merging this in. Thanks for letting us know.
Closing this for now. |
Please only review and do not merge - I want to orchestrate the deletion of snippets from UltiSnips, adding snippets here and releasing UltiSnips 3.0. I think I have push rights to the repo.
This pr moves the current snippets from UltiSnips into vim-snippets. When this is merged all UltiSnips snippets are curated in this repository and I take on maintenance of the UltiSnips/* files.
This PR also cleans up the README and removes the outdated and neglected AUTHORs file. See inline comments for my reasoning for changes in README - these are the only thing that need review really.