Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Local Auth and beta api token implementation #463

Merged
merged 33 commits into from
Sep 17, 2024
Merged

Local Auth and beta api token implementation #463

merged 33 commits into from
Sep 17, 2024

Conversation

mtmr0x
Copy link
Contributor

@mtmr0x mtmr0x commented Sep 5, 2024

No description provided.

@mtmr0x mtmr0x marked this pull request as ready for review September 16, 2024 16:41
mtmr0x
mtmr0x commented Sep 16, 2024
View reviewed changes
.env.sample Outdated Show resolved Hide resolved
gateway/api/localauth/login.go Outdated Show resolved Hide resolved
gateway/api/localauth/register.go Outdated Show resolved Hide resolved
gateway/api/localauth/register.go Outdated Show resolved Hide resolved
gateway/api/middleware.go Show resolved Hide resolved
gateway/api/middleware.go Outdated Show resolved Hide resolved
gateway/api/middleware.go Outdated Show resolved Hide resolved
gateway/api/middleware.go Show resolved Hide resolved
gateway/security/idp/authenticator.go Show resolved Hide resolved
webapp/src/webapp/subs.cljs Outdated Show resolved Hide resolved
@mtmr0x mtmr0x requested review from sandromello and rogefm and removed request for sandromello September 16, 2024 17:53
@mtmr0x mtmr0x changed the title wip(auth) new local auth feature Local Auth and beta api token implementation Sep 16, 2024
rogefm
rogefm reviewed Sep 16, 2024
View reviewed changes
gateway/api/middleware.go Outdated Show resolved Hide resolved
gateway/api/middleware.go Outdated Show resolved Hide resolved
gateway/api/middleware.go Outdated Show resolved Hide resolved
gateway/api/middleware.go Outdated Show resolved Hide resolved
gateway/api/server.go Outdated Show resolved Hide resolved
gateway/pgrest/orgs/orgs.go Outdated Show resolved Hide resolved
gateway/pgrest/users/users.go Outdated Show resolved Hide resolved
webapp/src/webapp/auth/local/login.cljs Outdated Show resolved Hide resolved
webapp/src/webapp/auth/local/register.cljs Outdated Show resolved Hide resolved
sandromello
sandromello requested changes Sep 16, 2024
View reviewed changes
Copy link
Contributor

@sandromello sandromello left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please, remove all fmt.Print... statements and add make sure to add a log.Infof|Warnf|Error to http errors 4xx and 5xx.

gateway/api/middleware.go Outdated Show resolved Hide resolved
gateway/api/middleware.go Show resolved Hide resolved
gateway/api/middleware.go Outdated Show resolved Hide resolved
gateway/api/middleware.go Show resolved Hide resolved
gateway/api/user/user.go Outdated Show resolved Hide resolved
gateway/api/localauth/register.go Outdated Show resolved Hide resolved
gateway/api/middleware.go Outdated Show resolved Hide resolved
gateway/transport/interceptors/auth/auth.go Outdated Show resolved Hide resolved
gateway/api/localauth/register.go Outdated Show resolved Hide resolved
gateway/api/localauth/register.go Outdated Show resolved Hide resolved
@mtmr0x mtmr0x merged commit 8aea06e into main Sep 17, 2024
1 check passed
@mtmr0x mtmr0x deleted the feature/auth-improvements branch September 17, 2024 13:35
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sandromello sandromello sandromello approved these changes

@rogefm rogefm Awaiting requested review from rogefm

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@mtmr0x @sandromello @rogefm