Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[FEAT]: New create connection #502

Merged
merged 12 commits into from
Oct 10, 2024
Merged

[FEAT]: New create connection #502

merged 12 commits into from
Oct 10, 2024

Conversation

rogefm
Copy link
Contributor

@rogefm rogefm commented Oct 8, 2024 •
edited
Loading

Figma -> https://www.figma.com/design/GhiQ0r5qL37UV9WTS8LBsj/Main?node-id=2631-17772&node-type=instance&m=dev

Checklist:

  • New create connection UI
  • New update connection UI
  • Rules for creating a new connection
  • Rules for updating a connection
  • New UI components
    • Dialog
    • Modal
    • Accordion
    • Input
    • Select
    • Text area
  • Delete old files
  • Colors in Tailwind/Radix

We removed icon_name from the create and update connection source code in this new implementation.

@rogefm rogefm requested a review from mtmr0x October 8, 2024 14:20
@rogefm rogefm marked this pull request as ready for review October 8, 2024 14:21
@rogefm rogefm force-pushed the feat/new-creating-connections branch from 22386f8 to 62a9a40 Compare October 8, 2024 14:24
mtmr0x
mtmr0x requested changes Oct 8, 2024
View reviewed changes
webapp/src/webapp/components/accordion.cljs Outdated Show resolved Hide resolved
webapp/src/webapp/components/accordion.cljs Outdated Show resolved Hide resolved
webapp/src/webapp/components/accordion.cljs Outdated Show resolved Hide resolved
webapp/src/webapp/components/dialog.cljs Outdated Show resolved Hide resolved
webapp/src/webapp/connections/views/create_update_connection/connection_environment_form.cljs Outdated Show resolved Hide resolved
webapp/src/webapp/connections/views/create_update_connection/connection_environment_form.cljs Show resolved Hide resolved
webapp/src/webapp/connections/views/create_update_connection/connection_environment_form.cljs Show resolved Hide resolved
webapp/src/webapp/connections/views/create_update_connection/connection_type_form.cljs Show resolved Hide resolved
webapp/src/webapp/connections/views/create_update_connection/main.cljs Outdated Show resolved Hide resolved
@rogefm rogefm requested a review from mtmr0x October 9, 2024 17:59
@rogefm rogefm merged commit 6d3e798 into main Oct 10, 2024
1 check passed
@rogefm rogefm deleted the feat/new-creating-connections branch October 10, 2024 20:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sandromello sandromello sandromello approved these changes

@mtmr0x mtmr0x mtmr0x approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@rogefm @sandromello @mtmr0x