Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Slack integration #199

Merged
merged 20 commits into from
Nov 17, 2017
Merged

Slack integration #199

merged 20 commits into from
Nov 17, 2017

Conversation

lkysow
Copy link
Collaborator

@lkysow lkysow commented Nov 17, 2017

No description provided.

@codecov-io
Copy link

Codecov Report

Merging #199 into master will increase coverage by 0.37%.
The diff coverage is 69.34%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #199      +/-   ##
==========================================
+ Coverage   63.54%   63.91%   +0.37%     
==========================================
  Files          35       38       +3     
  Lines        1986     2123     +137     
==========================================
+ Hits         1262     1357      +95     
- Misses        683      716      +33     
- Partials       41       50       +9
Impacted Files Coverage Δ
cmd/server.go 76.72% <ø> (ø) ⬆️
server/events/apply_executor.go 0% <0%> (ø) ⬆️
server/events/webhooks/slack_client.go 100% <100%> (ø)
server/server.go 75.21% <20%> (-3.72%) ⬇️
server/events/webhooks/slack.go 57.14% <57.14%> (ø)
server/events/webhooks/webhooks.go 67.56% <67.56%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update cc015af...cad3147. Read the comment docs.

@lkysow lkysow merged commit 9dc9434 into master Nov 17, 2017
@lkysow lkysow deleted the slack-integration branch November 17, 2017 04:13
@codec
Copy link
Contributor

codec commented Nov 17, 2017

@lkysow just wondering, shouldn't this PR also include the vendored dependencies and updated Gopkg.lock?

@lkysow
Copy link
Collaborator Author

lkysow commented Nov 17, 2017

@codec right you are, fixed in #202. I have no idea how that passed CI...

@codec
Copy link
Contributor

codec commented Nov 17, 2017

Circle CI always fetches them. Might be a bad idea: https://github.com/hootsuite/atlantis/blob/master/.circleci/config.yml#L13

@nadavshatz
Copy link
Contributor

Great stuff guys - if you include some info around how to use/set-this-up I can open a PR with changes to the Readme.

Cheers

@lkysow
Copy link
Collaborator Author

lkysow commented Nov 19, 2017

@nadavshatz yep, tracking that in #200. I found a couple things we need to fix first. Right now, we need the slack bot user to join the channel before it can post messages to it so need to add that.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants