Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update server.go #228

Closed
wants to merge 1 commit into from
Closed

Update server.go #228

wants to merge 1 commit into from

Conversation

cooling75
Copy link

A "nil" always results in a default client. Not sure but the maybe custom specified GitlabHostname should be included here?

A "nil" always results in a gitlab.com address. Not sure but the GitlabHostname should be included here?
@CLAassistant
Copy link

CLAassistant commented Jan 12, 2018

CLA assistant check
All committers have signed the CLA.

@lkysow
Copy link
Collaborator

lkysow commented Jan 15, 2018

@cooling75 thanks for the PR! Can you take a look at #229? According to #227 (comment) your change might not work?

Does #229 look like it does what you need?

@cooling75
Copy link
Author

@lkysow Yep, saw that too, #229 will do the trick. Thank you 👍

@cooling75 cooling75 closed this Jan 15, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants